Skip to content

Conversation

@nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jan 12, 2021

Reflects the changes done in #10940

Based on Subsumes #11082

Introduces ParamClause

    /** A parameter clause `[X1, ..., Xn]` or `(x1: X1, ..., xn: Xx)`
     *
     *  `[X1, ..., Xn]` are reresented with `TypeParamClause` and `(x1: X1, ..., xn: Xx)` are represented with `TermParamClause`
     *
     *  `ParamClause` encodes the following enumeration
     *  ```scala
     *  enum ParamClause:
     *    case TypeParamClause(params: List[TypeDef])
     *    case TermParamClause(params: List[ValDef])
     *  ```
     */
    type ParamClause <: AnyRef

Technically, ParamClause is like an opaque type on List[ValDef] | List[TypeDef] with some extra invariants that we need to ensure.

@nicolasstucki nicolasstucki force-pushed the update-param-clauses branch 2 times, most recently from 061c5fc to 310d910 Compare January 12, 2021 16:05
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented Jan 12, 2021

Blocked by #11076

@nicolasstucki nicolasstucki force-pushed the update-param-clauses branch 2 times, most recently from 4631a49 to 18baed1 Compare January 13, 2021 08:20
@nicolasstucki nicolasstucki added this to the 3.0.0-RC1 milestone Jan 13, 2021
@nicolasstucki nicolasstucki self-assigned this Jan 13, 2021
@nicolasstucki nicolasstucki force-pushed the update-param-clauses branch 4 times, most recently from 0aa0081 to 9248e79 Compare January 13, 2021 12:39
@nicolasstucki nicolasstucki marked this pull request as ready for review January 13, 2021 13:39
@nicolasstucki nicolasstucki linked an issue Jan 15, 2021 that may be closed by this pull request
@nicolasstucki nicolasstucki force-pushed the update-param-clauses branch 2 times, most recently from 75f7c1d to 9633b10 Compare January 18, 2021 11:56
@nicolasstucki nicolasstucki added the release-notes Should be mentioned in the release notes label Jan 18, 2021
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki
Copy link
Contributor Author

Rebased on top of #11145

@nicolasstucki nicolasstucki merged commit cc8ffb1 into scala:master Jan 19, 2021
@nicolasstucki nicolasstucki deleted the update-param-clauses branch January 19, 2021 13:10
@Kordyjan Kordyjan modified the milestones: 3.0.0-RC1, 3.0.0 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes Should be mentioned in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

community-docs CI is using the non-bootstrapped library

3 participants