-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ParamClause to allow multiple type param clauses #11074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolasstucki
merged 1 commit into
scala:master
from
dotty-staging:update-param-clauses
Jan 19, 2021
Merged
Add ParamClause to allow multiple type param clauses #11074
nicolasstucki
merged 1 commit into
scala:master
from
dotty-staging:update-param-clauses
Jan 19, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
061c5fc to
310d910
Compare
Contributor
Author
|
|
4631a49 to
18baed1
Compare
0aa0081 to
9248e79
Compare
9248e79 to
475bba4
Compare
75f7c1d to
9633b10
Compare
liufengyun
approved these changes
Jan 19, 2021
Contributor
liufengyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
compiler/src-non-bootstrapped/scala/quoted/runtime/impl/QuotesImpl.scala
Show resolved
Hide resolved
9633b10 to
5b4139f
Compare
Contributor
Author
|
Rebased on top of #11145 |
Reflects the changes done in scala#10940
5b4139f to
c50aa96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects the changes done in #10940
Based onSubsumes #11082Introduces
ParamClauseTechnically,
ParamClauseis like an opaque type onList[ValDef] | List[TypeDef]with some extra invariants that we need to ensure.